[frontend] Fix Specific Workflow for Request Access not shown in settings (#16017)#16099
Open
fellowseb wants to merge 2 commits into
Open
[frontend] Fix Specific Workflow for Request Access not shown in settings (#16017)#16099fellowseb wants to merge 2 commits into
fellowseb wants to merge 2 commits into
Conversation
github-actions
Bot
added
the
filigran team
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #16099 +/- ##
=======================================
Coverage 27.89% 27.90%
=======================================
Files 3232 3232
Lines 221679 221681 +2
Branches 37939 37944 +5
=======================================
+ Hits 61840 61858 +18
+ Misses 159839 159823 -16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fellowseb
force-pushed
the
issue/16017-broken-request-access
branch
from
6f29697 to
8a67c2c
Compare
fellowseb
force-pushed
the
issue/16017-broken-request-access
branch
from
8a67c2c to
93ec7bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Specific Workflow for Request Accesssection not shown in UI anymore after recent UI changesRegression introduced by deletion of
opencti-platform/opencti-front/src/private/components/settings/sub_types/SubTypeOverview.tsxin https://github.com/OpenCTI-Platform/opencti/pull/15372/changes#diff-88bfdd68a0105b4a5465ef6d0c614a637442f41f7eaebf08df364cbcf584f670L60 .Related issues
Test instructions
Checklist
Further comments
I considered (and tried) doing the EE check in the backend but it has a lot more implications as we are creating request-access-related entities during the init stage. Also correctly handling a CE -> EE transition at runtime without a restart of the platform would be involved. Before the regression the check was done in the UI too.